External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-31 22:17:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

virt-aa-helper: Fix return value of add_file_path

Browse Source 
Commit a885334499 added this
function and wrapped vah_add_file in it. vah_add_file may
return -1, 0, 1. It returns 1 in case the call to valid_path
detects a restricted file. The original code treated a return
value != 0 as error. The refactored code treats a return
value < 0 as error. This triggers segfault in virt-aa-helper
and breaks virt-aa-helper-test for the restricted file tests.

Make sure that add_file_path returns -1 on error.
This commit is contained in:
Matthias Bolte 2010-07-23 18:27:43 +02:00
parent 05c9a41336
commit adde0e2cf6
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/security/virt-aa-helper.c
View File

@ -818,6 +818,9 @@ add_file_path(virDomainDiskDefPtr disk,
ret = vah_add_file(buf, path, "r");
}
if (ret != 0)
ret = -1;
return ret;
}