External/libvirt
1
0
Fork 0
Code

virnetsocket: Revert part of g_steal_pointer() rewrite

Browse Source 
Turns out, the way that glib implements g_steal_pointer() is not
compatible with function callbacks. And that's what my recent
patch did in virNetSocketEventFree(). Revert that part.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Michal Privoznik 2021-03-24 16:49:39 +01:00
parent 228a87d307
commit af09d7a37a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/rpc/virnetsocket.c
View File

@ -2156,9 +2156,10 @@ static void virNetSocketEventFree(void *opaque)
void *eopaque; void *eopaque;
virObjectLock(sock); virObjectLock(sock);
ff = g_steal_pointer(&sock->ff); ff = sock->ff;
eopaque = g_steal_pointer(&sock->opaque); eopaque = g_steal_pointer(&sock->opaque);
sock->func = NULL; sock->func = NULL;
sock->ff = NULL;
virObjectUnlock(sock); virObjectUnlock(sock);
if (ff) if (ff)