mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 21:55:25 +00:00
docs: publish correct enum values
We publish libvirt-api.xml for others to use, and in fact, the libvirt-python bindings use it to generate python constants that correspond to our enum values. However, we had an off-by-one bug that any enum that relied on C's rules for implicit initialization of the first enum member to 0 got listed in the xml as having a value of 1 (and all later members of the enum were equally botched). The fix is simple - since we add one to the previous value when encountering an enum without an initializer, the previous value must start at -1 so that the first enum member is assigned 0. The python generator code has had the off-by-one ever since DV first wrote it years ago, but most of our public enums were immune because they had an explicit = 0 initializer. The only affected enums are: - virDomainEventGraphicsAddressType (such as VIR_DOMAIN_EVENT_GRAPHICS_ADDRESS_IPV4), since commit987e31e
(libvirt v0.8.0) - virDomainCoreDumpFormat (such as VIR_DOMAIN_CORE_DUMP_FORMAT_RAW), since commit9fbaff0
(libvirt v1.2.3) - virIPAddrType (such as VIR_IP_ADDR_TYPE_IPV4), since commit03e0e79
(not yet released) Thanks to Nehal J Wani for reporting the problem on IRC, and for helping me zero in on the culprit function. * docs/apibuild.py (CParser.parseEnumBlock): Fix implicit enum values. Signed-off-by: Eric Blake <eblake@redhat.com> (cherry picked from commit9b291bbe20
) Conflicts: docs/apibuild.py - context with2a40951
This commit is contained in:
parent
0e307ecf94
commit
b096e69474
@ -1303,7 +1303,7 @@ class CParser:
|
|||||||
name = None
|
name = None
|
||||||
self.comment = None
|
self.comment = None
|
||||||
comment = ""
|
comment = ""
|
||||||
value = "0"
|
value = "-1"
|
||||||
while token != None:
|
while token != None:
|
||||||
if token[0] == "sep" and token[1] == "{":
|
if token[0] == "sep" and token[1] == "{":
|
||||||
token = self.token()
|
token = self.token()
|
||||||
|
Loading…
Reference in New Issue
Block a user