mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-09 15:00:07 +00:00
vircommand: Initialize dryRunStatus to portable EXIT_SUCCESS instead of 0
If dry run of a command was requested (virCommandSetDryRun()) then a specified callback is called instead of running actual command. This is meant to be used in tests. To mimic running the command as closely as possible the callback can also set exit status of the command it's implementing. To save some lines though, the exit status is initialized to 0 so that callback has to set it only on failures. Now, 0 is not exactly portable value - that's why stdlib.h has EXIT_SUCCESS (and EXIT_FAILURE) values. Initialize the exit status (held in dryRunStatus) to EXIT_SUCCESS then. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
parent
716243f1f7
commit
b103200bf3
@ -2630,7 +2630,7 @@ virCommandRunAsync(virCommand *cmd, pid_t *pid)
|
||||
|
||||
if (dryRunBuffer || dryRunCallback) {
|
||||
g_autofree char *cmdstr = NULL;
|
||||
dryRunStatus = 0;
|
||||
dryRunStatus = EXIT_SUCCESS;
|
||||
|
||||
if (!(cmdstr = virCommandToStringFull(cmd, dryRunBufferArgLinebreaks,
|
||||
dryRunBufferCommandStripPath)))
|
||||
|
Loading…
Reference in New Issue
Block a user