External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-27 16:15:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: more verbose error when failing to create macvtap device

Browse Source 
Investigation of a problem with creating passthrough macvtap devices
(https://bugzilla.redhat.com/show_bug.cgi?id=1185501) has shown that
this slightly more verbose failure message is useful. In particular,
the mac address can be used to determine the domain. You could also
figure this out by looking at preceding messages in a debug log, but
this gets it in a single place.

(cherry picked from commit 72423df992)
This commit is contained in:
Laine Stump 2015-03-18 14:27:05 -04:00 committed by Cole Robinson
parent 2c3aba719a
commit b10e27ada5
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/util/virnetdevmacvlan.c
View File

@ -107,6 +107,7 @@ virNetDevMacVLanCreate(const char *ifname,
unsigned int recvbuflen; unsigned int recvbuflen;
struct nl_msg *nl_msg; struct nl_msg *nl_msg;
struct nlattr *linkinfo, *info_data; struct nlattr *linkinfo, *info_data;
char macstr[VIR_MAC_STRING_BUFLEN];
if (virNetDevGetIndex(srcdev, &ifindex) < 0) if (virNetDevGetIndex(srcdev, &ifindex) < 0)
return -1; return -1;
@ -177,8 +178,9 @@ virNetDevMacVLanCreate(const char *ifname,
default: default:
virReportSystemError(-err->error, virReportSystemError(-err->error,
_("error creating %s type of interface attach to %s"), _("error creating %s interface %s@%s (%s)"),
type, srcdev); type, ifname, srcdev,
virMacAddrFormat(macaddress, macstr));
goto cleanup; goto cleanup;
} }
break; break;