External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-11 07:17:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

hyperv: do not overwrite errors from hypervInvokeMethod()

Browse Source 
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Neal Gompa <ngompa13@gmail.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Matt Coleman 2020-10-22 12:38:24 -04:00 committed by Michal Privoznik
parent f1c406a9aa
commit b1a06feed7
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/hyperv/hyperv_driver.c
View File

@ -1800,11 +1800,8 @@ hypervDomainSendKey(virDomainPtr domain, unsigned int codeset,
if (hypervAddSimpleParam(params, "keyCode", keycodeStr) < 0) if (hypervAddSimpleParam(params, "keyCode", keycodeStr) < 0)
goto cleanup; goto cleanup;
if (hypervInvokeMethod(priv, &params, NULL) < 0) { if (hypervInvokeMethod(priv, &params, NULL) < 0)
virReportError(VIR_ERR_INTERNAL_ERROR, _("Could not press key %d"),
translatedKeycodes[i]);
goto cleanup; goto cleanup;
}
} }
/* simulate holdtime by sleeping */ /* simulate holdtime by sleeping */
@ -1823,11 +1820,8 @@ hypervDomainSendKey(virDomainPtr domain, unsigned int codeset,
if (hypervAddSimpleParam(params, "keyCode", keycodeStr) < 0) if (hypervAddSimpleParam(params, "keyCode", keycodeStr) < 0)
goto cleanup; goto cleanup;
if (hypervInvokeMethod(priv, &params, NULL) < 0) { if (hypervInvokeMethod(priv, &params, NULL) < 0)
virReportError(VIR_ERR_INTERNAL_ERROR,
_("Could not release key %s"), keycodeStr);
goto cleanup; goto cleanup;
}
} }
result = 0; result = 0;
@ -1919,10 +1913,8 @@ hypervDomainSetMemoryFlags(virDomainPtr domain, unsigned long memory,
} }
} }
if (hypervInvokeMethod(priv, &params, NULL) < 0) { if (hypervInvokeMethod(priv, &params, NULL) < 0)
virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Could not set memory"));
goto cleanup; goto cleanup;
}
result = 0; result = 0;