mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-03-07 17:28:15 +00:00
qemu: Reject 'preserve' action for 'on_reboot'/'on_poweroff'/'on_crash'
The qemu driver didn't ever implement any meaningful handling for the 'preserve' action. Forbid the flag in the qemu def validator and update the documentation to be factual. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
parent
507e608835
commit
b1b85a475f
@ -1747,8 +1747,7 @@ Each of these states allow for the same four possible actions.
|
||||
supported by the libxl hypervisor driver.)
|
||||
|
||||
QEMU/KVM supports the ``on_poweroff`` and ``on_reboot`` events handling the
|
||||
``destroy`` and ``restart`` actions. The ``preserve`` action for an
|
||||
``on_reboot`` event is treated as a ``destroy``.
|
||||
``destroy`` and ``restart`` actions.
|
||||
|
||||
The ``on_crash`` event supports these additional actions :since:`since 0.8.4` .
|
||||
|
||||
|
@ -1079,6 +1079,16 @@ qemuValidateLifecycleAction(virDomainLifecycleAction onPoweroff,
|
||||
return -1;
|
||||
}
|
||||
|
||||
/* The qemu driver doesn't yet implement any meaningful handling for
|
||||
* VIR_DOMAIN_LIFECYCLE_ACTION_PRESERVE */
|
||||
if (onPoweroff == VIR_DOMAIN_LIFECYCLE_ACTION_PRESERVE ||
|
||||
onReboot == VIR_DOMAIN_LIFECYCLE_ACTION_PRESERVE ||
|
||||
onCrash == VIR_DOMAIN_LIFECYCLE_ACTION_PRESERVE) {
|
||||
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||
_("qemu driver doesn't support the 'preserve' action for 'on_reboot'/'on_poweroff'/'on_crash'"));
|
||||
return -1;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user