External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: Refer to virReportOOMError in the HACKING file

Browse Source 
Instead of refering to __virRaiseError(VIR_ERROR_NO_MEMORY).
This commit is contained in:
Matthias Bolte 2010-01-30 12:35:04 +01:00
parent a6b00cbb16
commit b1cd474c77
2 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
HACKING
View File

@ -171,7 +171,7 @@ routines, use the macros from memory.h
virDomainPtr domain;
if (VIR_ALLOC(domain) < 0) {
__virRaiseError(VIR_ERROR_NO_MEMORY)
virReportOOMError(NULL);
return NULL;
}
@ -182,7 +182,7 @@ routines, use the macros from memory.h
int ndomains = 10;
if (VIR_ALLOC_N(domains, ndomains) < 0) {
__virRaiseError(VIR_ERROR_NO_MEMORY)
virReportOOMError(NULL);
return NULL;
}
@ -192,7 +192,7 @@ routines, use the macros from memory.h
int ndomains = 10;
if (VIR_ALLOC_N(domains, ndomains) < 0) {
__virRaiseError(VIR_ERROR_NO_MEMORY)
virReportOOMError(NULL);
return NULL;
}
@ -201,7 +201,7 @@ routines, use the macros from memory.h
ndomains = 20
if (VIR_REALLOC_N(domains, ndomains) < 0) {
__virRaiseError(VIR_ERROR_NO_MEMORY)
virReportOOMError(NULL);
return NULL;
}
@ -297,7 +297,7 @@ eg typical usage is as follows:
if (virBufferError(&buf)) {
virBufferFreeAndReset(&buf);
virReportOOMError(...);
virReportOOMError(NULL);
return NULL;
}
@ -385,7 +385,7 @@ to build:
- if a recently commited patch breaks compilation on a platform
or for a given driver then it's fine to commit a minimal fix
directly without getting the review feedback first
- similary if make check or make syntax-chek breaks, if there is
- similary if make check or make syntax-check breaks, if there is
an obvious fix, it's fine to commit immediately
The patch should still be sent to the list (or tell what the fix was if
trivial) and 'make check syntax-check' should pass too before commiting

12
docs/hacking.html.in
View File

@ -192,7 +192,7 @@
virDomainPtr domain;
if (VIR_ALLOC(domain) &lt; 0) {
__virRaiseError(VIR_ERROR_NO_MEMORY)
virReportOOMError(NULL);
return NULL;
}
</pre></li>
@ -204,7 +204,7 @@
int ndomains = 10;
if (VIR_ALLOC_N(domains, ndomains) &lt; 0) {
__virRaiseError(VIR_ERROR_NO_MEMORY)
virReportOOMError(NULL);
return NULL;
}
</pre></li>
@ -216,7 +216,7 @@
int ndomains = 10;
if (VIR_ALLOC_N(domains, ndomains) &lt; 0) {
__virRaiseError(VIR_ERROR_NO_MEMORY)
virReportOOMError(NULL);
return NULL;
}
</pre></li>
@ -227,7 +227,7 @@
ndomains = 20
if (VIR_REALLOC_N(domains, ndomains) &lt; 0) {
__virRaiseError(VIR_ERROR_NO_MEMORY)
virReportOOMError(NULL);
return NULL;
}
</pre></li>
@ -314,7 +314,7 @@
if (virBufferError(&amp;buf)) {
virBufferFreeAndReset(&amp;buf);
virReportOOMError(...);
virReportOOMError(NULL);
return NULL;
}
@ -419,7 +419,7 @@
<li>if a recently commited patch breaks compilation on a platform
or for a given driver then it's fine to commit a minimal fix
directly without getting the review feedback first</li>
<li>if make check or make syntax-chek breaks, if there is
<li>if make check or make syntax-check breaks, if there is
an obvious fix, it's fine to commit immediately.
The patch should still be sent to the list (or tell what the fix was if
trivial) and 'make check syntax-check' should pass too before commiting