From b1dcd198fa02599ff1db02cfd03b2f556b9b4496 Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Fri, 8 Jun 2012 13:41:25 +0200 Subject: [PATCH] client rpc: Improve debug messages in virNetClientIO When analyzing our debug log, I'm always confused about what each of the pointers mean. Let's be explicit. (cherry picked from commit 71689f95ceedbc63953a0b06aa2c2cee7fabfa2b) --- src/rpc/virnetclient.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index d88288d920..0943c11201 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1555,7 +1555,8 @@ static int virNetClientIO(virNetClientPtr client, return -1; } - VIR_DEBUG("Going to sleep %p %p", client->waitDispatch, thiscall); + VIR_DEBUG("Going to sleep head=%p call=%p", + client->waitDispatch, thiscall); /* Go to sleep while other thread is working... */ if (virCondWait(&thiscall->cond, &client->lock) < 0) { virNetClientCallRemove(&client->waitDispatch, thiscall); @@ -1564,7 +1565,8 @@ static int virNetClientIO(virNetClientPtr client, return -1; } - VIR_DEBUG("Wokeup from sleep %p %p", client->waitDispatch, thiscall); + VIR_DEBUG("Woken up from sleep head=%p call=%p", + client->waitDispatch, thiscall); /* Three reasons we can be woken up * 1. Other thread has got our reply ready for us * 2. Other thread is all done, and it is our turn to @@ -1596,7 +1598,8 @@ static int virNetClientIO(virNetClientPtr client, client->haveTheBuck = true; } - VIR_DEBUG("We have the buck %p %p", client->waitDispatch, thiscall); + VIR_DEBUG("We have the buck head=%p call=%p", + client->waitDispatch, thiscall); /* * The buck stops here! @@ -1625,7 +1628,8 @@ static int virNetClientIO(virNetClientPtr client, rv = -1; cleanup: - VIR_DEBUG("All done with our call %p %p %d", client->waitDispatch, thiscall, rv); + VIR_DEBUG("All done with our call head=%p call=%p rv=%d", + client->waitDispatch, thiscall, rv); return rv; }