External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

VBox bug when starting machine from old versions

Browse Source 
* src/vbox/vbox_tmpl.c: fix a bug where one can't start domains defined
  with older builds or with empty "FRONTEND/Type" tag in their xml
  files.
This commit is contained in:
Pritesh Kothari 2009-09-14 17:37:13 +02:00 committed by Daniel Veillard
parent f2ad7824aa
commit b22d935dbe
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/vbox/vbox_tmpl.c
View File

@ -2850,6 +2850,13 @@ static int vboxDomainCreate(virDomainPtr dom) {
vrdpPresent = 1; vrdpPresent = 1;
} }
if (!vrdpPresent && !sdlPresent && !guiPresent) {
/* if nothing is selected it means either the machine xml
* file is really old or some values are missing so fallback
*/
guiPresent = 1;
}
data->pFuncs->pfnUtf8Free(valueTypeUtf8); data->pFuncs->pfnUtf8Free(valueTypeUtf8);
} else { } else {
@ -2882,12 +2889,12 @@ static int vboxDomainCreate(virDomainPtr dom) {
data->pFuncs->pfnUtf8ToUtf16("vrdp", &sessionType); data->pFuncs->pfnUtf8ToUtf16("vrdp", &sessionType);
} }
data->vboxObj->vtbl->OpenRemoteSession(data->vboxObj, rc = data->vboxObj->vtbl->OpenRemoteSession(data->vboxObj,
data->vboxSession, data->vboxSession,
iid, iid,
sessionType, sessionType,
env, env,
&progress ); &progress );
if (NS_FAILED(rc)) { if (NS_FAILED(rc)) {
vboxError(dom->conn, VIR_ERR_OPERATION_FAILED, vboxError(dom->conn, VIR_ERR_OPERATION_FAILED,
"%s", "openremotesession failed, domain can't be started"); "%s", "openremotesession failed, domain can't be started");