mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 21:55:25 +00:00
Really don't crash if a connection closes early
https://bugzilla.redhat.com/show_bug.cgi?id=1047577 When writing commit173c291
, I missed the fact virNetServerClientClose unlocks the client object before actually clearing client->sock and thus it is possible to hit a window when client->keepalive is NULL while client->sock is not NULL. I was thinking client->sock == NULL was a better check for a closed connection but apparently we have to go with client->keepalive == NULL to actually fix the crash. Signed-off-by: Jiri Denemark <jdenemar@redhat.com> (cherry picked from commit066c8ef6c1
)
This commit is contained in:
parent
21fb70f048
commit
b24979a12f
@ -1379,7 +1379,7 @@ virNetServerClientStartKeepAlive(virNetServerClientPtr client)
|
||||
/* The connection might have been closed before we got here and thus the
|
||||
* keepalive object could have been removed too.
|
||||
*/
|
||||
if (!client->sock) {
|
||||
if (!client->keepalive) {
|
||||
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
||||
_("connection not open"));
|
||||
goto cleanup;
|
||||
|
Loading…
Reference in New Issue
Block a user