External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: use insertAt instead of j

Browse Source 
We call VIR_INSERT_ELEMENT_INPLACE either with 0 (for primary video)
or def->nvideos (for the rest).

Use a variable with more semantic name, since j is usually used
for iterating.
This commit is contained in:
Ján Tomko 2016-04-11 14:45:46 +02:00
parent ca70db398e
commit b2b8fc919d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/conf/domain_conf.c
View File

@ -16420,8 +16420,8 @@ virDomainDefParseXML(xmlDocPtr xml,
if (n && VIR_ALLOC_N(def->videos, n) < 0) if (n && VIR_ALLOC_N(def->videos, n) < 0)
goto error; goto error;
for (i = 0; i < n; i++) { for (i = 0; i < n; i++) {
j = def->nvideos;
virDomainVideoDefPtr video; virDomainVideoDefPtr video;
ssize_t insertAt = -1;
if (!(video = virDomainVideoDefParseXML(nodes[i], def, flags))) if (!(video = virDomainVideoDefParseXML(nodes[i], def, flags)))
goto error; goto error;
@ -16434,11 +16434,11 @@ virDomainDefParseXML(xmlDocPtr xml,
goto error; goto error;
} }
j = 0; insertAt = 0;
primaryVideo = true; primaryVideo = true;
} }
if (VIR_INSERT_ELEMENT_INPLACE(def->videos, if (VIR_INSERT_ELEMENT_INPLACE(def->videos,
j, insertAt,
def->nvideos, def->nvideos,
video) < 0) { video) < 0) {
virDomainVideoDefFree(video); virDomainVideoDefFree(video);