External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-03 16:42:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid use of uninitialized data in virnetmessagetest

Browse Source 
If an error occurs in virnetmessagetest it was possible it
would free uninitialized data.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2013-09-25 15:37:10 +01:00
parent a93eb09a97
commit b32ac57ee5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/virnetmessagetest.c
View File

@ -327,6 +327,8 @@ static int testMessagePayloadDecode(const void *args ATTRIBUTE_UNUSED)
};
int ret = -1;
memset(&err, 0, sizeof(err));
if (!msg)
return -1;
@ -334,7 +336,6 @@ static int testMessagePayloadDecode(const void *args ATTRIBUTE_UNUSED)
if (VIR_ALLOC_N(msg->buffer, msg->bufferLength) < 0)
goto cleanup;
memcpy(msg->buffer, input_buffer, msg->bufferLength);
memset(&err, 0, sizeof(err));
if (virNetMessageDecodeLength(msg) < 0) {
VIR_DEBUG("Failed to decode message header");