External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Code

remoteOpenConn: Pass correct variable to virConnectSetIdentity()

Browse Source 
The remoteOpenConn() function was refactored recently. As a part
of that new variable @newconn was introduced which holds
virConnect object as it's being gradually constructed throughout
the function. At the very end, when everything succeeded the
variable is stolen into passed @conn. However, there was one
line missed in the refactor which still access the @conn instead
of @newconn leading to a NULL dereference.

Fixes: f7c422993e4c7ca3e58b1d0d69f4772851af399f
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Michal Privoznik 2022-05-19 09:54:16 +02:00
parent 577c336151
commit b3e2fea3e8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/remote/remote_daemon_dispatch.c
View File

@ -1829,7 +1829,7 @@ remoteOpenConn(const char *uri,
VIR_DEBUG("Opened driver %p", newconn);
if (preserveIdentity) {
if (virConnectSetIdentity(*conn, identparams->par, identparams->npar, 0) < 0)
if (virConnectSetIdentity(newconn, identparams->par, identparams->npar, 0) < 0)
return -1;
VIR_DEBUG("Forwarded current identity to secondary driver");