External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

chExtractVersionInfo: Don't check for retversion != NULL

Browse Source 
The only caller, chExtractVersion() passes not NULL. Therefore,
it's redundant to check for NULL.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Michal Privoznik 2021-06-04 14:19:15 +02:00
parent 6fcbedad40
commit b5fcd27a08
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/ch/ch_conf.c
View File

@ -201,8 +201,7 @@ chExtractVersionInfo(int *retversion)
g_autofree char *ch_cmd = g_find_program_in_path(CH_CMD); g_autofree char *ch_cmd = g_find_program_in_path(CH_CMD);
virCommand *cmd = virCommandNewArgList(ch_cmd, "--version", NULL); virCommand *cmd = virCommandNewArgList(ch_cmd, "--version", NULL);
if (retversion) *retversion = 0;
*retversion = 0;
virCommandAddEnvString(cmd, "LC_ALL=C"); virCommandAddEnvString(cmd, "LC_ALL=C");
virCommandSetOutputBuffer(cmd, &help); virCommandSetOutputBuffer(cmd, &help);
@ -231,9 +230,7 @@ chExtractVersionInfo(int *retversion)
goto cleanup; goto cleanup;
} }
if (retversion) *retversion = version;
*retversion = version;
ret = 0; ret = 0;
cleanup: cleanup: