From b62b8090b2ad4524a5bf9d40d0d1c17a9d57f5a0 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Tue, 6 Feb 2018 10:21:56 +0100 Subject: [PATCH] qemu: Check for down limit of SLIRP prefix too https://bugzilla.redhat.com/show_bug.cgi?id=1515533 We're already checking if IPv4 prefix isn't too long. But we are not checking if it isn't too short. QEMU supports prefixes longer than 4 (including). I haven't find anything similar related to IPv6 in qemu sources. Signed-off-by: Michal Privoznik Reviewed-by: John Ferlan --- src/qemu/qemu_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index b60bb465a1..2bc0259eae 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3873,9 +3873,9 @@ qemuDomainDeviceDefValidateNetwork(const virDomainNetDef *net) } hasIPv4 = true; - if (ip->prefix > 27) { + if (ip->prefix < 4 || ip->prefix > 27) { virReportError(VIR_ERR_XML_ERROR, "%s", - _("prefix too long")); + _("invalid prefix, must be in range of 4-27")); return -1; } }