External/libvirt
1
0
Fork 0
Code

libvirt-admin: Add missing API arguments in debug printings

Browse Source 
Each public API is required to log all arguments it was called
with. Except, there are some missing. Fix them.

Signed-off-by: Han Han <hhan@redhat.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Han Han 2019-08-09 14:29:41 +08:00 committed by Michal Privoznik
parent d8326cb882
commit b67c1f3d02
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/libvirt-admin.c
View File

@ -222,7 +222,7 @@ virAdmConnectOpen(const char *name, unsigned int flags)
if (virAdmInitialize() < 0) if (virAdmInitialize() < 0)
goto error; goto error;
VIR_DEBUG("flags=0x%x", flags); VIR_DEBUG("name=%s flags=0x%x", NULLSTR(name), flags);
virResetLastError(); virResetLastError();
if (!(conn = virAdmConnectNew())) if (!(conn = virAdmConnectNew()))
@ -1034,7 +1034,8 @@ virAdmServerGetClientLimits(virAdmServerPtr srv,
{ {
int ret = -1; int ret = -1;
VIR_DEBUG("srv=%p, flags=0x%x", srv, flags); VIR_DEBUG("srv=%p, params=%p, nparams=%p, flags=0x%x",
srv, params, nparams, flags);
virResetLastError(); virResetLastError();
virCheckAdmServerGoto(srv, error); virCheckAdmServerGoto(srv, error);
@ -1159,7 +1160,8 @@ virAdmConnectGetLoggingFilters(virAdmConnectPtr conn,
{ {
int ret = -1; int ret = -1;
VIR_DEBUG("conn=%p, flags=0x%x", conn, flags); VIR_DEBUG("conn=%p, filters=%p, flags=0x%x",
conn, filters, flags);
virResetLastError(); virResetLastError();
virCheckAdmConnectReturn(conn, -1); virCheckAdmConnectReturn(conn, -1);
@ -1236,7 +1238,7 @@ virAdmConnectSetLoggingFilters(virAdmConnectPtr conn,
{ {
int ret = -1; int ret = -1;
VIR_DEBUG("conn=%p, flags=0x%x", conn, flags); VIR_DEBUG("conn=%p, filters=%s, flags=0x%x", conn, filters, flags);
virResetLastError(); virResetLastError();
virCheckAdmConnectReturn(conn, -1); virCheckAdmConnectReturn(conn, -1);