External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virfirewall: Don't check OOM in ADD_ARG macro

Browse Source 
VIR_RESIZE_N can't fail nowadays, adjust the macro.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
This commit is contained in:
Peter Krempa 2021-02-23 17:34:35 +01:00
parent 22dbafe092
commit b8aa25f560
1 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/util/virfirewall.c
View File

@ -262,10 +262,9 @@ void virFirewallFree(virFirewallPtr firewall)
#define ADD_ARG(rule, str) \
do { \
if (VIR_RESIZE_N(rule->args, \
rule->argsAlloc, \
rule->argsLen, 1) < 0) \
goto no_memory; \
ignore_value(VIR_RESIZE_N(rule->args, \
rule->argsAlloc, \
rule->argsLen, 1)); \
\
rule->args[rule->argsLen++] = g_strdup(str); \
} while (0)
@ -433,9 +432,6 @@ void virFirewallRuleAddArg(virFirewallPtr firewall,
ADD_ARG(rule, arg);
return;
no_memory:
firewall->err = ENOMEM;
}
@ -455,9 +451,6 @@ void virFirewallRuleAddArgFormat(virFirewallPtr firewall,
ADD_ARG(rule, arg);
return;
no_memory:
firewall->err = ENOMEM;
}
@ -473,9 +466,6 @@ void virFirewallRuleAddArgSet(virFirewallPtr firewall,
}
return;
no_memory:
firewall->err = ENOMEM;
}
@ -496,10 +486,6 @@ void virFirewallRuleAddArgList(virFirewallPtr firewall,
va_end(list);
return;
no_memory:
firewall->err = ENOMEM;
va_end(list);
}