External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

cpu_x86: Fix memory leak in virCPUx86Translate

Browse Source 
virCPUDefStealModel is called with keepVendor == true which means the
cpu structure will keep its original vendor/vendor_id values. Thus it
makes no sense to copy them to the translated definition as they won't
be used there anyway. Except that the translated->vendor pointer might
get lost in x86Decode.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
Jiri Denemark 2017-02-09 09:25:51 +01:00
parent eda4ec94ff
commit b97839b835
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cpu/cpu_x86.c
View File

@ -2709,10 +2709,6 @@ virCPUx86Translate(virCPUDefPtr cpu,
if (!(translated = virCPUDefCopyWithoutModel(cpu)))
goto cleanup;
if (VIR_STRDUP(translated->vendor, cpu->vendor) < 0 ||
VIR_STRDUP(translated->vendor_id, cpu->vendor_id) < 0)
goto cleanup;
if (x86Decode(translated, &model->data, models, nmodels, NULL, 0) < 0)
goto cleanup;