External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 03:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

examples: domtop: Avoid leaking memory

Browse Source 
Use the virTypedParamsFree unconditionally as it handles NULL well and
has the benefit of freeing a typed parameter array even if it wasn't yet
assigned, but only allocated.
This commit is contained in:
Peter Krempa 2014-07-21 09:53:17 +02:00
parent abab113bd2
commit ba2b4da02d
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
examples/domtop/domtop.c
View File

@ -334,12 +334,8 @@ do_top(virConnectPtr conn,
ret = 0; ret = 0;
cleanup: cleanup:
if (max_id > 0) { virTypedParamsFree(now_params, now_nparams * max_id);
if (now_nparams > 0) virTypedParamsFree(then_params, then_nparams * max_id);
virTypedParamsFree(now_params, now_nparams * max_id);
if (then_nparams > 0)
virTypedParamsFree(then_params, then_nparams * max_id);
}
if (dom) if (dom)
virDomainFree(dom); virDomainFree(dom);
return ret; return ret;