External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-08-28 03:21:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

secret: drop dead code

Browse Source 
Detected by Coverity.  The only ways to get to the cleanup label
were by an early abort (list still unassigned) or after successfully
transferring list to dest, so there is no list to clean up.

* src/secret/secret_driver.c (loadSecrets): Kill dead code.
This commit is contained in:
Eric Blake 2011-06-06 13:14:48 -06:00
parent 4eb17d642e
commit ba4983da47
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/secret/secret_driver.c
View File

@ -1,7 +1,7 @@
/*
* secret_driver.c: local driver for secret manipulation API
*
* Copyright (C) 2009-2010 Red Hat, Inc.
* Copyright (C) 2009-2011 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@ -516,12 +516,6 @@ loadSecrets(virSecretDriverStatePtr driver,
ret = 0;
cleanup:
while (list != NULL) {
virSecretEntryPtr s;
s = listUnlink(&list);
secretFree(s);
}
if (dir != NULL)
closedir(dir);
return ret;