mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-26 18:41:17 +00:00
Don't validate disk type in virsh attach-disk
Let the underlying driver tell us what it supports. At the moment we are at least erroneously denying floppy eject/insert.
This commit is contained in:
parent
5b13f4375d
commit
bb175dfc53
@ -1,3 +1,7 @@
|
|||||||
|
Tue May 19 09:04:05 EDT 2009 Cole Robinson <crobinso@redhat.com>
|
||||||
|
|
||||||
|
* src/virsh.c: Don't validate disk type in virsh attach-disk
|
||||||
|
|
||||||
Tue May 19 09:00:43 EDT 2009 Cole Robinson <crobinso@redhat.com>
|
Tue May 19 09:00:43 EDT 2009 Cole Robinson <crobinso@redhat.com>
|
||||||
|
|
||||||
* python/libvir.py: Don't overwrite legitimate python import error.
|
* python/libvir.py: Don't overwrite legitimate python import error.
|
||||||
|
@ -5509,13 +5509,6 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd)
|
|||||||
type = vshCommandOptString(cmd, "type", NULL);
|
type = vshCommandOptString(cmd, "type", NULL);
|
||||||
mode = vshCommandOptString(cmd, "mode", NULL);
|
mode = vshCommandOptString(cmd, "mode", NULL);
|
||||||
|
|
||||||
if (type) {
|
|
||||||
if (STRNEQ(type, "cdrom") && STRNEQ(type, "disk")) {
|
|
||||||
vshError(ctl, FALSE, _("No support %s in command 'attach-disk'"), type);
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (driver) {
|
if (driver) {
|
||||||
if (STREQ(driver, "file") || STREQ(driver, "tap")) {
|
if (STREQ(driver, "file") || STREQ(driver, "tap")) {
|
||||||
isFile = 1;
|
isFile = 1;
|
||||||
|
Loading…
Reference in New Issue
Block a user