External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: vircommand: fix redundant if

Browse Source 
Comparison "if (ret == -1)" is always false.
This statement was forgotten during switching to g_new0()

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 0275b06a55 ("util: command: use g_new0")
Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Dmitry Frolov 2023-10-10 11:54:14 +03:00 committed by Martin Kletzander
parent d448eccf69
commit bb673117d5
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/util/vircommand.c
View File

@ -2227,7 +2227,7 @@ virCommandProcessIO(virCommand *cmd)
int outfd = -1, errfd = -1; int outfd = -1, errfd = -1;
size_t inlen = 0, outlen = 0, errlen = 0; size_t inlen = 0, outlen = 0, errlen = 0;
size_t inoff = 0; size_t inoff = 0;
int ret = 0; int ret = -1;
g_autofree struct pollfd *fds = NULL; g_autofree struct pollfd *fds = NULL;
if (dryRunBuffer || dryRunCallback) { if (dryRunBuffer || dryRunCallback) {
@ -2254,9 +2254,6 @@ virCommandProcessIO(virCommand *cmd)
VIR_FREE(*cmd->errbuf); VIR_FREE(*cmd->errbuf);
*cmd->errbuf = g_new0(char, 1); *cmd->errbuf = g_new0(char, 1);
} }
if (ret == -1)
goto cleanup;
ret = -1;
fds = g_new0(struct pollfd, 3 + virCommandGetNumSendBuffers(cmd)); fds = g_new0(struct pollfd, 3 + virCommandGetNumSendBuffers(cmd));