External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

conf: consistent comments about disk enum usage

Browse Source 
Before refactoring this struct, I found it helpful to track which
'int' fields really contain an enum value.

* src/conf/domain_conf.h (_virDomainDiskDef): Add comments.

Signed-off-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Eric Blake 2014-03-19 09:09:02 -06:00
parent dcb69a183a
commit bbd5d83020
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/conf/domain_conf.h
View File

@ -494,7 +494,7 @@ struct _virDomainHostdevDef {
virDomainDeviceInfoPtr info; /* Guest address */ virDomainDeviceInfoPtr info; /* Guest address */
}; };
/* Two types of disk backends */ /* Types of disk backends (host resource) */
enum virDomainDiskType { enum virDomainDiskType {
VIR_DOMAIN_DISK_TYPE_BLOCK, VIR_DOMAIN_DISK_TYPE_BLOCK,
VIR_DOMAIN_DISK_TYPE_FILE, VIR_DOMAIN_DISK_TYPE_FILE,
@ -505,7 +505,7 @@ enum virDomainDiskType {
VIR_DOMAIN_DISK_TYPE_LAST VIR_DOMAIN_DISK_TYPE_LAST
}; };
/* Three types of disk frontend */ /* Types of disk frontend (guest view) */
enum virDomainDiskDevice { enum virDomainDiskDevice {
VIR_DOMAIN_DISK_DEVICE_DISK, VIR_DOMAIN_DISK_DEVICE_DISK,
VIR_DOMAIN_DISK_DEVICE_CDROM, VIR_DOMAIN_DISK_DEVICE_CDROM,
@ -529,7 +529,7 @@ enum virDomainDiskBus {
VIR_DOMAIN_DISK_BUS_LAST VIR_DOMAIN_DISK_BUS_LAST
}; };
enum virDomainDiskCache { enum virDomainDiskCache {
VIR_DOMAIN_DISK_CACHE_DEFAULT, VIR_DOMAIN_DISK_CACHE_DEFAULT,
VIR_DOMAIN_DISK_CACHE_DISABLE, VIR_DOMAIN_DISK_CACHE_DISABLE,
VIR_DOMAIN_DISK_CACHE_WRITETHRU, VIR_DOMAIN_DISK_CACHE_WRITETHRU,
@ -540,7 +540,7 @@ enum virDomainDiskCache {
VIR_DOMAIN_DISK_CACHE_LAST VIR_DOMAIN_DISK_CACHE_LAST
}; };
enum virDomainDiskErrorPolicy { enum virDomainDiskErrorPolicy {
VIR_DOMAIN_DISK_ERROR_POLICY_DEFAULT, VIR_DOMAIN_DISK_ERROR_POLICY_DEFAULT,
VIR_DOMAIN_DISK_ERROR_POLICY_STOP, VIR_DOMAIN_DISK_ERROR_POLICY_STOP,
VIR_DOMAIN_DISK_ERROR_POLICY_REPORT, VIR_DOMAIN_DISK_ERROR_POLICY_REPORT,
@ -580,7 +580,7 @@ enum virDomainDiskTray {
VIR_DOMAIN_DISK_TRAY_LAST VIR_DOMAIN_DISK_TRAY_LAST
}; };
enum virDomainDiskGeometryTrans { enum virDomainDiskGeometryTrans {
VIR_DOMAIN_DISK_TRANS_DEFAULT = 0, VIR_DOMAIN_DISK_TRANS_DEFAULT = 0,
VIR_DOMAIN_DISK_TRANS_NONE, VIR_DOMAIN_DISK_TRANS_NONE,
VIR_DOMAIN_DISK_TRANS_AUTO, VIR_DOMAIN_DISK_TRANS_AUTO,
@ -598,7 +598,7 @@ struct _virDomainDiskHostDef {
char *socket; /* path to unix socket */ char *socket; /* path to unix socket */
}; };
enum virDomainDiskIo { enum virDomainDiskIo {
VIR_DOMAIN_DISK_IO_DEFAULT, VIR_DOMAIN_DISK_IO_DEFAULT,
VIR_DOMAIN_DISK_IO_NATIVE, VIR_DOMAIN_DISK_IO_NATIVE,
VIR_DOMAIN_DISK_IO_THREADS, VIR_DOMAIN_DISK_IO_THREADS,
@ -707,14 +707,14 @@ typedef virDomainDiskSourcePoolDef *virDomainDiskSourcePoolDefPtr;
/* Stores the virtual disk configuration */ /* Stores the virtual disk configuration */
struct _virDomainDiskDef { struct _virDomainDiskDef {
int type; int type; /* enum virDomainDiskType */
int device; int device; /* enum virDomainDiskDevice */
int bus; int bus; /* enum virDomainDiskBus */
char *src; char *src;
char *dst; char *dst;
int tray_status; int tray_status; /* enum virDomainDiskTray */
int removable; int removable; /* enum virDomainFeatureState */
int protocol; int protocol; /* enum virDomainDiskProtocol */
size_t nhosts; size_t nhosts;
virDomainDiskHostDefPtr hosts; virDomainDiskHostDefPtr hosts;
virDomainDiskSourcePoolDefPtr srcpool; virDomainDiskSourcePoolDefPtr srcpool;
@ -738,7 +738,7 @@ struct _virDomainDiskDef {
unsigned int cylinders; unsigned int cylinders;
unsigned int heads; unsigned int heads;
unsigned int sectors; unsigned int sectors;
int trans; int trans; /* enum virDomainDiskGeometryTrans */
} geometry; } geometry;
struct { struct {
@ -752,13 +752,13 @@ struct _virDomainDiskDef {
char *wwn; char *wwn;
char *vendor; char *vendor;
char *product; char *product;
int cachemode; int cachemode; /* enum virDomainDiskCache */
int error_policy; /* enum virDomainDiskErrorPolicy */ int error_policy; /* enum virDomainDiskErrorPolicy */
int rerror_policy; /* enum virDomainDiskErrorPolicy */ int rerror_policy; /* enum virDomainDiskErrorPolicy */
int iomode; int iomode; /* enum virDomainDiskIo */
int ioeventfd; int ioeventfd; /* enum virDomainIoEventFd */
int event_idx; int event_idx; /* enum virDomainVirtioEventIdx */
int copy_on_read; int copy_on_read; /* enum virDomainDiskCopyOnRead */
int snapshot; /* enum virDomainSnapshotLocation, snapshot_conf.h */ int snapshot; /* enum virDomainSnapshotLocation, snapshot_conf.h */
int startupPolicy; /* enum virDomainStartupPolicy */ int startupPolicy; /* enum virDomainStartupPolicy */
bool readonly; bool readonly;