External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

ch_driver: Add additional validation for save/restore

Browse Source 
Save & Restore are supported without any network and hostdev config
defined. So, add a validation for it before performing save.

Signed-off-by: Purna Pavan Chandra Aekkaladevi <paekkaladevi@linux.microsoft.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Purna Pavan Chandra Aekkaladevi 2024-03-11 09:44:05 +00:00 committed by Michal Privoznik
parent f2d54f42d5
commit bcd567faa2
1 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/ch/ch_driver.c
View File

@ -679,6 +679,26 @@ chDomainDestroy(virDomainPtr dom)
return chDomainDestroyFlags(dom, 0);
}
static int
chDomainSaveAdditionalValidation(virDomainDef *vmdef)
{
/*
SAVE and RESTORE are functional only without any networking and
device passthrough configuration
*/
if (vmdef->nnets > 0) {
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
_("cannot save domain with network interfaces"));
return -1;
}
if (vmdef->nhostdevs > 0) {
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
_("cannot save domain with host devices"));
return -1;
}
return 0;
}
/**
* chDoDomainSave:
* @driver: pointer to driver structure
@ -701,13 +721,17 @@ chDoDomainSave(virCHDriver *driver,
g_autoptr(virCHDriverConfig) cfg = virCHDriverGetConfig(driver);
virCHDomainObjPrivate *priv = vm->privateData;
CHSaveXMLHeader hdr;
virDomainState domainState;
g_autofree char *to = NULL;
g_autofree char *xml = NULL;
uint32_t xml_len;
VIR_AUTOCLOSE fd = -1;
int ret = -1;
virDomainState domainState = virDomainObjGetState(vm, NULL);
if (chDomainSaveAdditionalValidation(vm->def) < 0)
goto end;
domainState = virDomainObjGetState(vm, NULL);
if (domainState == VIR_DOMAIN_RUNNING) {
if (virCHMonitorSuspendVM(priv->monitor) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",