External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-01 20:05:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: optparse: Use --config with the setmaxmem command

Browse Source 
The virsh-optparse test broke after commit 6ac402c456 because it
always assumed the max memory limit can be adjusted on a running domain
which used to be the case in the old code.
This is only a hot fix for the CI build. The proper fix here is to
re-write the whole test in a self-test/unit-test manner where we only
test virsh's ability to parse various values, not running actual
commands.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Acked-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Erik Skultety 2019-07-25 09:35:01 +02:00
parent a1c04c27bd
commit bd53501f07
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/virsh-optparse
View File

@ -219,13 +219,13 @@ test -s out && fail=1
compare exp-err err || fail=1
# Numeric value with valid suffix
virsh -q -c $test_url setmaxmem test 42MB >out 2>err || fail=1
virsh -q -c $test_url setmaxmem test 42MB --config >out 2>err || fail=1
test -s out && fail=1
test -s err && fail=1
# Numeric value bigger than INT_MAX. No failure here because
# scaled numeric values are unsigned long long
virsh -q -c $test_url setmaxmem test 2147483648 >out 2>err || fail=1
virsh -q -c $test_url setmaxmem test 2147483648 --config >out 2>err || fail=1
test -s out && fail=1
test -s err && fail=1
@ -248,7 +248,7 @@ test -s out && fail=1
compare exp-err err || fail=1
# Numeric value
virsh -q -c $test_url setmaxmem test 42 >out 2>err || fail=1
virsh -q -c $test_url setmaxmem test 42 --config >out 2>err || fail=1
test -s out && fail=1
test -s err && fail=1