External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

qemu: Fix a possible deadlock in p2p migration

Browse Source 
The function virUnrefConnect() may call virReleaseConnect() to release
the dest connection, and the function virReleaseConnect() will call
conn->driver->close().

So the function virUnrefConnect() should be surrounded by
qemuDomainObjEnterRemoteWithDriver() and
qemuDomainObjExitRemoteWithDriver() to prevent possible deadlock between
two communicating libvirt daemons.

See commit f0c8e1cb3774d6f09e2681ca1988bf235a343007 for further details.

Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
This commit is contained in:
Wen Congyang 2011-01-21 16:28:07 +08:00 committed by Eric Blake
parent 3703c3fed4
commit bda57661b8
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_driver.c
View File

@ -8790,7 +8790,9 @@ static int doPeer2PeerMigrate(virDomainPtr dom,
cleanup: cleanup:
VIR_FREE(dom_xml); VIR_FREE(dom_xml);
/* don't call virConnectClose(), because that resets any pending errors */ /* don't call virConnectClose(), because that resets any pending errors */
qemuDomainObjEnterRemoteWithDriver(driver, vm);
virUnrefConnect(dconn); virUnrefConnect(dconn);
qemuDomainObjExitRemoteWithDriver(driver, vm);
return ret; return ret;
} }