External/libvirt
1
0
Fork 0
Code

virCommandPassFD: Give name to flags

Browse Source 
The flags passed to virCommandPassFD() are unnamed and
documentation to this function doesn't list them either.
Give them name and mention it in documentation to functions
using them.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Laine Stump <laine@laine.org>
This commit is contained in:
Michal Privoznik 2018-03-21 17:17:54 +01:00
parent b56db91bc3
commit c02736059a
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/util/vircommand.c
View File

@ -173,9 +173,9 @@ virCommandFDIsSet(virCommandPtr cmd,
/* /*
* virCommandFDSet: * virCommandFDSet:
* @fd: FD to be put into @set * @cmd: pointer to virCommand
* @set: the set * @fd: file descriptor to pass
* @set_size: actual size of @set * @flags: extra flags; binary-OR of virCommandPassFDFlags
* *
* This is practically generalized implementation * This is practically generalized implementation
* of FD_SET() as we do not want to be limited * of FD_SET() as we do not want to be limited
@ -976,7 +976,7 @@ virCommandNewVAList(const char *binary, va_list list)
* virCommandPassFD: * virCommandPassFD:
* @cmd: the command to modify * @cmd: the command to modify
* @fd: fd to reassign to the child * @fd: fd to reassign to the child
* @flags: the flags * @flags: extra flags; binary-OR of virCommandPassFDFlags
* *
* Transfer the specified file descriptor to the child, instead * Transfer the specified file descriptor to the child, instead
* of closing it on exec. @fd must not be one of the three * of closing it on exec. @fd must not be one of the three

4
src/util/vircommand.h
View File

@ -51,10 +51,10 @@ virCommandPtr virCommandNewVAList(const char *binary, va_list list)
* delayed until the Run/RunAsync methods * delayed until the Run/RunAsync methods
*/ */
enum { typedef enum {
/* Close the FD in the parent */ /* Close the FD in the parent */
VIR_COMMAND_PASS_FD_CLOSE_PARENT = (1 << 0), VIR_COMMAND_PASS_FD_CLOSE_PARENT = (1 << 0),
}; } virCommandPassFDFlags;
void virCommandPassFD(virCommandPtr cmd, void virCommandPassFD(virCommandPtr cmd,
int fd, int fd,