External/libvirt
1
0
Fork 0
Code

qemuGetDHCPInterfaces: Move some variables inside the loop

Browse Source 
Some variables are not used outside of the for() loop. Move their
declaration to clean up the code a bit.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Michal Privoznik 2019-12-04 09:55:52 +01:00
parent dae430ccbc
commit c06f4b48fe
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/qemu/qemu_driver.c
View File

@ -21722,26 +21722,27 @@ qemuGetDHCPInterfaces(virDomainObjPtr vm,
virDomainInterfacePtr **ifaces) virDomainInterfacePtr **ifaces)
{ {
g_autoptr(virConnect) conn = NULL; g_autoptr(virConnect) conn = NULL;
virDomainInterfacePtr *ifaces_ret = NULL;
size_t ifaces_count = 0;
int rv = -1; int rv = -1;
int n_leases = 0; int n_leases = 0;
size_t i, j;
size_t ifaces_count = 0;
g_autoptr(virNetwork) network = NULL;
char macaddr[VIR_MAC_STRING_BUFLEN];
virDomainInterfacePtr iface = NULL;
virNetworkDHCPLeasePtr *leases = NULL; virNetworkDHCPLeasePtr *leases = NULL;
virDomainInterfacePtr *ifaces_ret = NULL; size_t i;
if (!(conn = virGetConnectNetwork())) if (!(conn = virGetConnectNetwork()))
return -1; return -1;
for (i = 0; i < vm->def->nnets; i++) { for (i = 0; i < vm->def->nnets; i++) {
g_autoptr(virNetwork) network = NULL;
char macaddr[VIR_MAC_STRING_BUFLEN];
virDomainInterfacePtr iface = NULL;
size_t j;
if (vm->def->nets[i]->type != VIR_DOMAIN_NET_TYPE_NETWORK) if (vm->def->nets[i]->type != VIR_DOMAIN_NET_TYPE_NETWORK)
continue; continue;
virMacAddrFormat(&(vm->def->nets[i]->mac), macaddr); virMacAddrFormat(&(vm->def->nets[i]->mac), macaddr);
virObjectUnref(network);
network = virNetworkLookupByName(conn, network = virNetworkLookupByName(conn,
vm->def->nets[i]->data.network.name); vm->def->nets[i]->data.network.name);
if (!network) if (!network)