External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

domain: Fix migratable XML with graphics/@listen

Browse Source 
As of commit 6992994, we set graphics/@listen attribute according to the
first listen child element even if that element is of type='network'.
This was done for backward compatibility with applications which only
support the original listen attribute. However, by doing so we broke
migration to older libvirt which tried to check that the listen
attribute matches one of the listen child elements but which did not
take type='network' elements into account.

We are not concerned about compatibility with old applications when
formatting domain XML for migration for two reasons. The XML is consumed
only by libvirtd and the IP address associated with type='network'
listen address on the source host is just useless on the destination
host. Thus, we can safely avoid propagating the type='network' IP
address to graphics/@listen attribute when creating migratable XML.

https://bugzilla.redhat.com/show_bug.cgi?id=1265111

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
Jiri Denemark 2015-09-23 14:48:06 +02:00
parent 2d9fcb3102
commit c0806dc30b
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/conf/domain_conf.c
View File

@ -21020,19 +21020,17 @@ virDomainGraphicsDefFormat(virBufferPtr buf,
* <graphics>. This is done to improve backward compatibility. * <graphics>. This is done to improve backward compatibility.
*/ */
for (i = 0; i < def->nListens; i++) { for (i = 0; i < def->nListens; i++) {
virDomainGraphicsListenType listenType;
if (flags & VIR_DOMAIN_DEF_FORMAT_MIGRATABLE && if (flags & VIR_DOMAIN_DEF_FORMAT_MIGRATABLE &&
def->listens[i].fromConfig) def->listens[i].fromConfig)
continue; continue;
listenType = virDomainGraphicsListenGetType(def, i);
if (listenType == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS || if (def->listens[i].type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK &&
(listenType == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK && flags & (VIR_DOMAIN_DEF_FORMAT_INACTIVE |
!(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE))) { VIR_DOMAIN_DEF_FORMAT_MIGRATABLE))
if ((listenAddr = virDomainGraphicsListenGetAddress(def, i))) continue;
break;
} if ((listenAddr = virDomainGraphicsListenGetAddress(def, i)))
break;
} }
virBufferAsprintf(buf, "<graphics type='%s'", type); virBufferAsprintf(buf, "<graphics type='%s'", type);