External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 04:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu_command: do use host-nodes for system memory

Browse Source 
After previous commit, it's no longer possible to change nodeset
for strict numatune. Therefore, we can start generating
host-nodes onto command line again.

This partially reverts d73265af6ec41104c20633b5c0a23688a62105e6.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Michal Privoznik 2021-12-15 16:46:27 +01:00
parent 06f405c627
commit c1355849e4
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/qemu/qemu_command.c
View File

@ -3896,8 +3896,7 @@ qemuBuildMemoryBackendProps(virJSONValue **backendProps,
/* If mode is "restrictive", we should only use cgroups setting allowed memory /* If mode is "restrictive", we should only use cgroups setting allowed memory
* nodes, and skip passing the host-nodes and policy parameters to QEMU command * nodes, and skip passing the host-nodes and policy parameters to QEMU command
* line which means we will use system default memory policy. */ * line which means we will use system default memory policy. */
if (!systemMemory && nodemask && if (nodemask && mode != VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE) {
mode != VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE) {
if (!virNumaNodesetIsAvailable(nodemask)) if (!virNumaNodesetIsAvailable(nodemask))
return -1; return -1;
if (virJSONValueObjectAdd(&props, if (virJSONValueObjectAdd(&props,

2
tests/qemuxml2argvdata/numatune-system-memory.x86_64-latest.args
View File

@ -14,7 +14,7 @@ XDG_CONFIG_HOME=/tmp/lib/domain--1-QEMUGuest1/.config \
-accel tcg \ -accel tcg \
-cpu qemu64 \ -cpu qemu64 \
-m 214 \ -m 214 \
-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}' \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264,"host-nodes":[0],"policy":"bind"}' \
-overcommit mem-lock=off \ -overcommit mem-lock=off \
-smp 2,sockets=2,cores=1,threads=1 \ -smp 2,sockets=2,cores=1,threads=1 \
-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ -uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \