External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-21 20:15:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: fix virBufferVasprintf on mingw

Browse Source 
Gnulib documents that mingw vsnprintf is broken (it returns -1
on out-of-space, instead of the count of what would have been
printed); but while we were using the snprintf wrapper, we had
not yet been using the vsnprintf wrapper.

Meanwhile, mingw (but not mingw64) has a replacement snprintf
that fixes return values, but still lacks %1$s support; so in
that case, gnulib didn't replace snprintf, but libintl then
went ahead and installed a version that supported %1$s but not
return values.  Gnulib has since been fixed to guarantee that
the snprintf module will always guarantee the constraints needed
by libintl.

Also, we want to guarantee that strdup sets errno on failure.

* .gnulib: Update to latest, for vsnprintf fix.
* bootstrap.conf (gnulib_modules): Add vsnprintf, strdup-posix.
Reported by Matthias Bolte.
This commit is contained in:
Eric Blake 2011-06-30 11:57:42 -06:00
parent a34e193fb7
commit c2dda6ebb3
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.gnulib

@ -1 +1 @@
Subproject commit 7269b35c8d9be1a6f97906b9e29b8c422b92fc31
Subproject commit c3153d2c0cf5f675ae13ae2bd1dee0f463b9c86a

2
bootstrap.conf
View File

@ -80,6 +80,7 @@ socket
stdarg
stpcpy
strchrnul
strdup-posix
strndup
strerror
strerror_r-posix
@ -97,6 +98,7 @@ usleep
vasprintf
verify
vc-list-files
vsnprintf
waitpid
warnings
'