From c43b69fea3925ac0179292aaa3129a0ec3bc4ba1 Mon Sep 17 00:00:00 2001 From: Andrea Bolognani Date: Thu, 30 Nov 2023 19:34:55 +0100 Subject: [PATCH] rpcgen: Skip generator tests on macOS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The generator can produce different code on Linux and macOS: specifically, on the former we want to use xdr_uint64_t while the latter needs xdr_u_int64_t instead. This is clearly a problem for tests that involve comparing the output produced against some expected output that's stored in the git repository. In the long run, we need to find a better way to handle this, but since 9.10.0 is going to be released very soon and we don't want it to have a broken test suite on macOS, simply skip the generator tests on that platform for now. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrangé --- scripts/rpcgen/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/rpcgen/meson.build b/scripts/rpcgen/meson.build index 7a8d505c61..7fb32c0f91 100644 --- a/scripts/rpcgen/meson.build +++ b/scripts/rpcgen/meson.build @@ -3,7 +3,7 @@ subdir('rpcgen') if tests_enabled[0] subdir('tests') - if pytest_prog.found() + if pytest_prog.found() and host_machine.system() != 'darwin' test( 'rpcgen-pytest', python3_prog,