External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-02 01:45:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage: do not leak storage pool XML filename

Browse Source 
Valgrind complained:

==28277== 38 bytes in 1 blocks are definitely lost in loss record 298 of 957
==28277==    at 0x4A06A2E: malloc (vg_replace_malloc.c:270)
==28277==    by 0x82D7F57: __vasprintf_chk (in /lib64/libc-2.12.so)
==28277==    by 0x52EF16A: virVasprintfInternal (stdio2.h:199)
==28277==    by 0x52EF25C: virAsprintfInternal (virstring.c:514)
==28277==    by 0x52B1FA9: virFileBuildPath (virfile.c:2831)
==28277==    by 0x19B1947C: storageDriverAutostart (storage_driver.c:191)
==28277==    by 0x19B196A7: storageStateAutoStart (storage_driver.c:307)
==28277==    by 0x538527E: virStateInitialize (libvirt.c:793)
==28277==    by 0x11D7CF: daemonRunStateInit (libvirtd.c:947)
==28277==    by 0x52F4694: virThreadHelper (virthread.c:206)
==28277==    by 0x6E08A50: start_thread (in /lib64/libpthread-2.12.so)
==28277==    by 0x82BE93C: clone (in /lib64/libc-2.12.so)

Signed-off-by: Michael Chapman <mike@very.puzzling.org>
This commit is contained in:
Michael Chapman 2015-12-31 17:04:40 +11:00 committed by Michal Privoznik
parent 28c9eea032
commit c494db8fd6
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/storage/storage_driver.c
View File

@ -151,7 +151,6 @@ static void
storageDriverAutostart(void) storageDriverAutostart(void)
{ {
size_t i; size_t i;
char *stateFile = NULL;
virConnectPtr conn = NULL; virConnectPtr conn = NULL;
/* XXX Remove hardcoding of QEMU URI */ /* XXX Remove hardcoding of QEMU URI */
@ -187,6 +186,8 @@ storageDriverAutostart(void)
} }
if (started) { if (started) {
char *stateFile;
virStoragePoolObjClearVols(pool); virStoragePoolObjClearVols(pool);
stateFile = virFileBuildPath(driver->stateDir, stateFile = virFileBuildPath(driver->stateDir,
pool->def->name, ".xml"); pool->def->name, ".xml");
@ -201,12 +202,11 @@ storageDriverAutostart(void)
VIR_ERROR(_("Failed to autostart storage pool '%s': %s"), VIR_ERROR(_("Failed to autostart storage pool '%s': %s"),
pool->def->name, err ? err->message : pool->def->name, err ? err->message :
_("no error message found")); _("no error message found"));
VIR_FREE(stateFile); } else {
virStoragePoolObjUnlock(pool);
continue;
}
pool->active = true; pool->active = true;
} }
VIR_FREE(stateFile);
}
virStoragePoolObjUnlock(pool); virStoragePoolObjUnlock(pool);
} }