External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-04-26 15:14:42 +00:00
Code

qemu: don't request cgroup ACL access for /dev/net/tun

Browse Source 
Since libvirt always passes /dev/net/tun to qemu via fd, we should
never trigger the cases where qemu tries to directly open the
device.  Therefore, it is safer to deny the cgroup device ACL.

* src/qemu/qemu_cgroup.c (defaultDeviceACL): Remove /dev/net/tun.
* src/qemu/qemu.conf (cgroup_device_acl): Reflect this change.
This commit is contained in:
Eric Blake 2011-03-09 15:05:00 -07:00
parent 5d09151341
commit c52cbe487c
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu.conf
View File

@ -182,7 +182,7 @@
# "/dev/null", "/dev/full", "/dev/zero", # "/dev/null", "/dev/full", "/dev/zero",
# "/dev/random", "/dev/urandom", # "/dev/random", "/dev/urandom",
# "/dev/ptmx", "/dev/kvm", "/dev/kqemu", # "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
# "/dev/rtc", "/dev/hpet", "/dev/net/tun", # "/dev/rtc", "/dev/hpet",
#] #]

2
src/qemu/qemu_cgroup.c
View File

@ -37,7 +37,7 @@ static const char *const defaultDeviceACL[] = {
"/dev/null", "/dev/full", "/dev/zero", "/dev/null", "/dev/full", "/dev/zero",
"/dev/random", "/dev/urandom", "/dev/random", "/dev/urandom",
"/dev/ptmx", "/dev/kvm", "/dev/kqemu", "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
"/dev/rtc", "/dev/hpet", "/dev/net/tun", "/dev/rtc", "/dev/hpet",
NULL, NULL,
}; };
#define DEVICE_PTY_MAJOR 136 #define DEVICE_PTY_MAJOR 136