mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-22 12:35:17 +00:00
test: Don't assume a configFile exists for Storage Pool tests
Fix a "bug" in the storage pool test driver code which "assumed" testStoragePoolObjSetDefaults should fill in the configFile for both the Define/Create (persistent) and CreateXML (transient) pools by just VIR_FREE()'ing it during CreateXML. Because the configFile was filled in, during Destroy the pool wouldn't be free'd which could cause issues for future patches which add tests to validate vHBA creation for the storage pool using the same name.
This commit is contained in:
parent
e3c37aa810
commit
c5781e37a0
@ -4439,6 +4439,12 @@ testStoragePoolCreateXML(virConnectPtr conn,
|
||||
pool = NULL;
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
/* *SetDefaults fills this in for the persistent pools, but this
|
||||
* would be a transient pool so remove it; otherwise, the Destroy
|
||||
* code will not Remove the pool */
|
||||
VIR_FREE(pool->configFile);
|
||||
|
||||
pool->active = 1;
|
||||
|
||||
event = virStoragePoolEventLifecycleNew(pool->def->name, pool->def->uuid,
|
||||
|
Loading…
x
Reference in New Issue
Block a user