External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 21:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Validate PCI controller options (numaNode)

Browse Source 
This change catches an invalid use of the option in our
test suite.

https://bugzilla.redhat.com/show_bug.cgi?id=1483816

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Laine Stump <laine@laine.org>
This commit is contained in:
Andrea Bolognani 2018-02-21 10:17:56 +01:00
parent 5bd8764ee0
commit c651cdbce6
3 changed files with 45 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
src/qemu/qemu_domain.c
View File

@ -4723,6 +4723,50 @@ qemuDomainDeviceDefValidateControllerPCI(const virDomainControllerDef *cont,
return -1; return -1;
} }
/* numaNode */
switch ((virDomainControllerModelPCI) cont->model) {
case VIR_DOMAIN_CONTROLLER_MODEL_PCI_EXPANDER_BUS:
case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_EXPANDER_BUS:
/* numaNode can be used for these controllers, but it's not set
* automatically so it can be missing */
break;
case VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT:
/* Only PHBs support numaNode */
if (pciopts->numaNode != -1 &&
pciopts->modelName != VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_SPAPR_PCI_HOST_BRIDGE) {
virReportControllerInvalidOption(cont, model, modelName, "numaNode");
return -1;
}
/* However, the default PHB doesn't support numaNode */
if (pciopts->numaNode != -1 &&
pciopts->modelName == VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_SPAPR_PCI_HOST_BRIDGE &&
pciopts->targetIndex == 0) {
virReportControllerInvalidOption(cont, model, modelName, "numaNode");
return -1;
}
break;
case VIR_DOMAIN_CONTROLLER_MODEL_PCI_BRIDGE:
case VIR_DOMAIN_CONTROLLER_MODEL_DMI_TO_PCI_BRIDGE:
case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT_PORT:
case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_SWITCH_UPSTREAM_PORT:
case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_SWITCH_DOWNSTREAM_PORT:
case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT:
if (pciopts->numaNode != -1) {
virReportControllerInvalidOption(cont, model, modelName, "numaNode");
return -1;
}
break;
case VIR_DOMAIN_CONTROLLER_MODEL_PCI_DEFAULT:
case VIR_DOMAIN_CONTROLLER_MODEL_PCI_LAST:
default:
virReportEnumRangeError(virDomainControllerModelPCI, cont->model);
return -1;
}
return qemuDomainDeviceDefValidateControllerPCIOld(cont, def, qemuCaps); return qemuDomainDeviceDefValidateControllerPCIOld(cont, def, qemuCaps);
} }

3
tests/qemuxml2argvdata/pcie-expander-bus.xml
View File

@ -35,9 +35,6 @@
<address type='pci' bus='0x00' slot='4'/> <address type='pci' bus='0x00' slot='4'/>
</controller> </controller>
<controller type='pci' index='2' model='pcie-root-port'> <controller type='pci' index='2' model='pcie-root-port'>
<target>
<node>1</node>
</target>
<address type='pci' bus='0x01'/> <address type='pci' bus='0x01'/>
</controller> </controller>
<controller type='pci' index='3' model='pcie-switch-upstream-port'> <controller type='pci' index='3' model='pcie-switch-upstream-port'>

4
tests/qemuxml2xmloutdata/pcie-expander-bus.xml
View File

@ -36,9 +36,7 @@
</controller> </controller>
<controller type='pci' index='2' model='pcie-root-port'> <controller type='pci' index='2' model='pcie-root-port'>
<model name='ioh3420'/> <model name='ioh3420'/>
<target chassis='2' port='0x0'> <target chassis='2' port='0x0'/>
<node>1</node>
</target>
<address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/> <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
</controller> </controller>
<controller type='pci' index='3' model='pcie-switch-upstream-port'> <controller type='pci' index='3' model='pcie-switch-upstream-port'>