External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: fixing wrong datatype of 'set-lifcycle-action' command options.

Browse Source 
The 'set-lifcycle-action' is throwing a weird error after executing it with
the '--help' option. The command output is showing the options 'type' and
'action' are as optional, but they aren't. Both are required.

virsh # set-lifecycle-action --help
...
  SYNOPSIS
    set-lifecycle-action <domain> [--type <string>] [--action <string>] ...
...
  OPTIONS
    [--domain] <string>  domain name, id or uuid
error: internal error: bad options in command: 'set-lifecycle-action'

After applying this patch, both arguments are required now.

virsh # set-lifecycle-action --help
...
  SYNOPSIS
    set-lifecycle-action <domain> <type> <action> [--config] ...

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509870

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
This commit is contained in:
Julio Faracco 2017-11-16 01:01:54 -02:00 committed by Michal Privoznik
parent 996500d6fa
commit c7543a7286
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/virsh-domain.c
View File

@ -5532,12 +5532,12 @@ static const vshCmdInfo info_setLifecycleAction[] = {
static const vshCmdOptDef opts_setLifecycleAction[] = { static const vshCmdOptDef opts_setLifecycleAction[] = {
VIRSH_COMMON_OPT_DOMAIN_FULL, VIRSH_COMMON_OPT_DOMAIN_FULL,
{.name = "type", {.name = "type",
.type = VSH_OT_STRING, .type = VSH_OT_DATA,
.flags = VSH_OFLAG_REQ, .flags = VSH_OFLAG_REQ,
.help = N_("lifecycle type to modify") .help = N_("lifecycle type to modify")
}, },
{.name = "action", {.name = "action",
.type = VSH_OT_STRING, .type = VSH_OT_DATA,
.flags = VSH_OFLAG_REQ, .flags = VSH_OFLAG_REQ,
.help = N_("lifecycle action to set") .help = N_("lifecycle action to set")
}, },