External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pass shutoff reason to release hook

Browse Source 
Sometimes in release hook it is useful to know if the VM shutdown was graceful
or not. This is especially useful to do cleanup based on the VM shutdown failure
reason in release hook. This patch proposes to use the last argument 'extra'
to pass VM shutoff reason in the call to release hook.
Making this change for Qemu and LXC.

Signed-off-by: Swapnil Ingle <swapnil.ingle@nutanix.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Swapnil Ingle 2024-06-18 16:39:58 +00:00 committed by Michal Privoznik
parent 2b199ad3f1
commit c772f1982d
3 changed files with 49 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
docs/hooks.rst
View File

@ -215,7 +215,30 @@ operation. There is no specific operation to indicate a "restart" is occurring.
::
/etc/libvirt/hooks/qemu guest_name release end -
/etc/libvirt/hooks/qemu guest_name release end <shutoff-reason>
+-------------------+-------------------------------------------------------------------+
| Shutoff reason | Description |
+===================+===================================================================+
| unknown | the reason is unknown |
+-------------------+-------------------------------------------------------------------+
| shutdown | normal shutdown |
+-------------------+-------------------------------------------------------------------+
| destroyed | forced poweroff |
+-------------------+-------------------------------------------------------------------+
| crashed | domain crashed |
+-------------------+-------------------------------------------------------------------+
| migrated | migrated to another host |
+-------------------+-------------------------------------------------------------------+
| saved | saved to a file |
+-------------------+-------------------------------------------------------------------+
| failed | domain failed to start |
+-------------------+-------------------------------------------------------------------+
| from snapshot | restored from a snapshot which was taken while domain was shutoff |
+-------------------+-------------------------------------------------------------------+
| daemon | daemon decides to kill domain during reconnection processing |
+-------------------+-------------------------------------------------------------------+
- :since:`Since 0.9.11`, the qemu hook script is also called at the beginning
of incoming migration. It is called as:
@ -312,7 +335,29 @@ operation. There is no specific operation to indicate a "restart" is occurring.
::
/etc/libvirt/hooks/lxc guest_name release end -
/etc/libvirt/hooks/lxc guest_name release end <shutoff-reason>
+-------------------+-------------------------------------------------------------------+
| Shutoff reason | Description |
+===================+===================================================================+
| unknown | the reason is unknown |
+-------------------+-------------------------------------------------------------------+
| shutdown | normal shutdown |
+-------------------+-------------------------------------------------------------------+
| destroyed | forced poweroff |
+-------------------+-------------------------------------------------------------------+
| crashed | domain crashed |
+-------------------+-------------------------------------------------------------------+
| migrated | migrated to another host |
+-------------------+-------------------------------------------------------------------+
| saved | saved to a file |
+-------------------+-------------------------------------------------------------------+
| failed | domain failed to start |
+-------------------+-------------------------------------------------------------------+
| from snapshot | restored from a snapshot which was taken while domain was shutoff |
+-------------------+-------------------------------------------------------------------+
| daemon | daemon decides to kill domain during reconnection processing |
+-------------------+-------------------------------------------------------------------+
- :since:`Since 0.9.13`, the lxc hook script is also called when the libvirtd
daemon restarts and reconnects to previously running LXC processes. If the

2
src/lxc/lxc_process.c
View File

@ -244,7 +244,7 @@ static void virLXCProcessCleanup(virLXCDriver *driver,
/* we can't stop the operation even if the script raised an error */
virHookCall(VIR_HOOK_DRIVER_LXC, vm->def->name,
VIR_HOOK_LXC_OP_RELEASE, VIR_HOOK_SUBOP_END,
NULL, xml, NULL);
virDomainShutoffReasonTypeToString(reason), xml, NULL);
}
if (flags & VIR_LXC_PROCESS_CLEANUP_REMOVE_TRANSIENT)

2
src/qemu/qemu_process.c
View File

@ -8722,7 +8722,7 @@ void qemuProcessStop(virQEMUDriver *driver,
/* we can't stop the operation even if the script raised an error */
virHookCall(VIR_HOOK_DRIVER_QEMU, vm->def->name,
VIR_HOOK_QEMU_OP_RELEASE, VIR_HOOK_SUBOP_END,
NULL, xml, NULL);
virDomainShutoffReasonTypeToString(reason), xml, NULL);
}
virDomainObjRemoveTransientDef(vm);