External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: fix virpidfile on mingw

Browse Source 
Regression introduced in commit b7e5ca4.

Mingw lacks kill(), but we were only using it for a sanity check;
so we can go with one less check.

Also, on OOM error, this function should outright fail rather than
claim that the pid file was successfully read.

* src/util/virpidfile.c (virPidFileReadPathIfAlive): Skip kill
call where unsupported, and report error on OOM.
This commit is contained in:
Eric Blake 2011-08-17 11:46:35 -06:00
parent 984840a2c2
commit c811de8fb7
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/util/virpidfile.c
View File

@ -200,15 +200,18 @@ int virPidFileReadPathIfAlive(const char *path,
if (rc < 0)
return rc;
/* Check that it's still alive */
#ifndef WIN32
/* Check that it's still alive. Safe to skip this sanity check on
* mingw, which lacks kill(). */
if (kill(*pid, 0) < 0) {
*pid = -1;
return 0;
}
#endif
if (virAsprintf(&procpath, "/proc/%d/exe", *pid) < 0) {
*pid = -1;
return 0;
return -1;
}
if (virFileIsLink(procpath) &&