External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-11 15:27:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: plug memory leak

Browse Source 
Leak detected by Coverity; only possible on unlikely ptsname_r
failure.  Additionally, the man page for ptsname_r states that
failure is merely non-zero, not necessarily -1.

* src/util/util.c (virFileOpenTtyAt): Avoid leak on ptsname_r
failure.
This commit is contained in:
Eric Blake 2011-08-02 16:21:37 -06:00
parent d69b79ab72
commit c86827a243
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/util/util.c
View File

@ -1126,8 +1126,10 @@ int virFileOpenTtyAt(const char *ptmx,
goto cleanup;
}
if (ptsname_r(*ttymaster, *ttyName, PATH_MAX) < 0)
if (ptsname_r(*ttymaster, *ttyName, PATH_MAX) != 0) {
VIR_FREE(*ttyName);
goto cleanup;
}
}
rc = 0;