External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

admin: Add a check to reject negative argument for number of typed params

Browse Source 
Since nparams can be technically negative, it is a good practice throughout
our code to check if nparams actually has a non-negative value. The same effect
would be achieved by converting our internal typed params serializer argument
to 'unsigned' type, but it definitely would not be the path of least resistance.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Erik Skultety 2016-05-03 17:04:42 +02:00
parent 71714e8549
commit ca0d45148d
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/libvirt-admin.c
View File

@ -838,6 +838,7 @@ virAdmServerSetThreadPoolParameters(virAdmServerPtr srv,
virCheckAdmServerReturn(srv, -1); virCheckAdmServerReturn(srv, -1);
virCheckNonNullArgGoto(params, error); virCheckNonNullArgGoto(params, error);
virCheckNonNegativeArgGoto(nparams, error);
if (remoteAdminServerSetThreadPoolParameters(srv, params, if (remoteAdminServerSetThreadPoolParameters(srv, params,
nparams, flags) < 0) nparams, flags) < 0)