External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: avoid PATH_MAX-sized array

Browse Source 
See previous patch for why this is good...

* src/test/test_driver.c (struct _testConn, testOpenFromFile)
(testClose): Manage path dynamically.
This commit is contained in:
Eric Blake 2011-06-22 14:03:30 -06:00
parent aa286e537d
commit ca8b4cec6d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/test/test_driver.c
View File

@ -77,7 +77,7 @@ typedef struct _testCell *testCellPtr;
struct _testConn {
virMutex lock;
char path[PATH_MAX];
char *path;
int nextDomID;
virCapsPtr caps;
virNodeInfo nodeInfo;
@ -790,9 +790,8 @@ static int testOpenFromFile(virConnectPtr conn,
privconn->nextDomID = 1;
privconn->numCells = 0;
if (virStrcpyStatic(privconn->path, file) == NULL) {
testError(VIR_ERR_INTERNAL_ERROR,
_("Path %s too big for destination"), file);
if ((privconn->path = strdup(file)) == NULL) {
virReportOOMError();
goto error;
}
memmove(&privconn->nodeInfo, &defaultNodeInfo, sizeof(defaultNodeInfo));
@ -1090,6 +1089,7 @@ static int testOpenFromFile(virConnectPtr conn,
virNetworkObjListFree(&privconn->networks);
virInterfaceObjListFree(&privconn->ifaces);
virStoragePoolObjListFree(&privconn->pools);
VIR_FREE(privconn->path);
testDriverUnlock(privconn);
VIR_FREE(privconn);
conn->privateData = NULL;
@ -1161,6 +1161,7 @@ static int testClose(virConnectPtr conn)
virInterfaceObjListFree(&privconn->ifaces);
virStoragePoolObjListFree(&privconn->pools);
virDomainEventStateFree(privconn->domainEventState);
VIR_FREE(privconn->path);
testDriverUnlock(privconn);
virMutexDestroy(&privconn->lock);