External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virLogParseFilters: Refactor string list handling

Browse Source 
Rewrite the code to remove the need to calculate the string list count.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2021-03-22 17:38:24 +01:00
parent aa8d253c1d
commit caa71d3028
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/util/virlog.c
View File

@ -1668,22 +1668,22 @@ int
virLogParseFilters(const char *src, virLogFilterPtr **filters) virLogParseFilters(const char *src, virLogFilterPtr **filters)
{ {
size_t nfilters = 0; size_t nfilters = 0;
size_t i, count;
g_auto(GStrv) strings = NULL; g_auto(GStrv) strings = NULL;
GStrv next;
virLogFilterPtr filter = NULL; virLogFilterPtr filter = NULL;
virLogFilterPtr *list = NULL; virLogFilterPtr *list = NULL;
VIR_DEBUG("filters=%s", src); VIR_DEBUG("filters=%s", src);
if (!(strings = virStringSplitCount(src, " ", 0, &count))) if (!(strings = g_strsplit(src, " ", 0)))
return -1; return -1;
for (i = 0; i < count; i++) { for (next = strings; *next; next++) {
/* virStringSplit may return empty strings */ /* g_strsplit may return empty strings */
if (STREQ(strings[i], "")) if (STREQ(*next, ""))
continue; continue;
if (!(filter = virLogParseFilter(strings[i]))) if (!(filter = virLogParseFilter(*next)))
return -1; return -1;
if (VIR_APPEND_ELEMENT(list, nfilters, filter)) { if (VIR_APPEND_ELEMENT(list, nfilters, filter)) {