From cabebc0c56c3581ec832c96747b85291cfbd8d87 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Wed, 27 Aug 2014 09:43:52 -0400 Subject: [PATCH] qemu_capabilities: Resolve Coverity NULL_RETURNS Adjust the initialization of qemuCaps() to check for a NULL before attempting to dereference like other callers/users do. --- src/qemu/qemu_capabilities.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 410086b2c6..ce899f210d 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3349,10 +3349,13 @@ virQEMUCapsPtr virQEMUCapsNewForBinary(const char *binary, uid_t runUid, gid_t runGid) { - virQEMUCapsPtr qemuCaps = virQEMUCapsNew(); + virQEMUCapsPtr qemuCaps; struct stat sb; int rv; + if (!(qemuCaps = virQEMUCapsNew())) + goto error; + if (VIR_STRDUP(qemuCaps->binary, binary) < 0) goto error;