External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-21 20:15:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

tools: Fix memory leak

Browse Source 
Coverity found that commit id 'c661b675f' needed to create a cleanup
path to handle the closing of 'fp' if the virBitmapNewQuiet failed.
This commit is contained in:
John Ferlan 2016-04-14 09:55:21 -04:00
parent 6c09c17e0d
commit cb31d618fd
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/virt-host-validate-common.c
View File

@ -194,13 +194,13 @@ int virHostValidateNamespace(const char *hvname,
virBitmapPtr virHostValidateGetCPUFlags(void)
{
FILE *fp;
virBitmapPtr flags;
virBitmapPtr flags = NULL;
if (!(fp = fopen("/proc/cpuinfo", "r")))
return NULL;
if (!(flags = virBitmapNewQuiet(VIR_HOST_VALIDATE_CPU_FLAG_LAST)))
return NULL;
goto cleanup;
do {
char line[1024];
@ -246,6 +246,7 @@ virBitmapPtr virHostValidateGetCPUFlags(void)
virStringFreeListCount(tokens, ntokens);
} while (1);
cleanup:
VIR_FORCE_FCLOSE(fp);
return flags;