External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-24 06:35:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Fix a race when computing migration downtime

Browse Source 
Computing a total downtime during a migration requires us to store a
time stamp when guest CPUs get stopped. The value (and all other
statistics) is then transferred to the destination to compute the
downtime. Because the stopped time stamp is stored by a STOP event
handler while the statistics which will be sent over to the destination
are copied synchronously within qemuMigrationWaitForCompletion.

Depending on the timing of STOP and MIGRATION events, we may end up
copying (and transferring) statistics without the stopped time stamp
set. Let's make sure we always use the correct time stamp.

https://bugzilla.redhat.com/show_bug.cgi?id=1282744

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
Jiri Denemark 2016-02-23 10:47:01 +01:00
parent 315808e99e
commit cb483a68fd
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_migration.c
View File

@ -4510,6 +4510,8 @@ qemuMigrationRun(virQEMUDriverPtr driver,
priv->job.current->type = VIR_DOMAIN_JOB_FAILED; priv->job.current->type = VIR_DOMAIN_JOB_FAILED;
goto cleanup; goto cleanup;
} }
if (priv->job.completed)
priv->job.completed->stopped = priv->job.current->stopped;
ret = 0; ret = 0;