From cbe4c049d87fe1f677668fbb51ba36647f3481d0 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 30 Jun 2016 14:33:24 +0200 Subject: [PATCH] conf: Don't free the constructed string in virDomainGetBlkioParametersAssignFromDef virTypedParameterAssign steals the string rather than copying it into the typed parameter and thus freeing it leads to a crash when attempting to serialize the results. This was introduced in commit 9f50f6e2 and later made an universal helper in 32e6339c. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1351473 --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7d40f26573..78e394d169 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -24936,7 +24936,7 @@ virDomainGetBlkioParametersAssignFromDef(virDomainDefPtr def, if (virTypedParameterAssign(&(params[(*nparams)++]), name, \ VIR_TYPED_PARAM_STRING, data) < 0) \ goto error; \ - VIR_FREE(data); \ + data = NULL; \ } /* blkiotune.device_weight */