External/libvirt
1
0
Fork 0
Code

Check for errors when parsing bridge interface XML

Browse Source 
The return status of virInterfaceDefParseBridge() was not being
checked, potentially resulting in the creation of a broken
interface.
This commit is contained in:
Jim Fehlig 2012-06-14 11:20:17 -06:00
parent b9852862ea
commit cc004a6647
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/conf/interface_conf.c
View File

@ -769,7 +769,8 @@ virInterfaceDefParseXML(xmlXPathContextPtr ctxt, int parentIfType) {
} }
def->data.bridge.delay = virXMLPropString(bridge, "delay"); def->data.bridge.delay = virXMLPropString(bridge, "delay");
ctxt->node = bridge; ctxt->node = bridge;
virInterfaceDefParseBridge(def, ctxt); if (virInterfaceDefParseBridge(def, ctxt) < 0)
goto error;
break; break;
} }
case VIR_INTERFACE_TYPE_BOND: { case VIR_INTERFACE_TYPE_BOND: {