External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-09-09 09:14:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

virnetsocket: Resolve Coverity RESOURCE_LEAK

Browse Source 
Since '1b807f92d' - Coverity complains that in the error paths of
both virFork() and virProcessWait() that the 'passfd' will not be closed.
Added the VIR_FORCE_CLOSE(passfd) and initialized it to -1.

Also noted that variable 'buf' was never really used - so I removed it
This commit is contained in:
John Ferlan 2014-08-22 11:01:04 -04:00
parent e1d0471e58
commit cc1bbbbeba
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/rpc/virnetsocket.c
View File

@ -544,8 +544,7 @@ int virNetSocketNewConnectUNIX(const char *path,
const char *binary,
virNetSocketPtr *retsock)
{
char *buf = NULL;
int fd, passfd;
int fd, passfd = -1;
virSocketAddr localAddr;
virSocketAddr remoteAddr;
@ -647,8 +646,8 @@ int virNetSocketNewConnectUNIX(const char *path,
return 0;
error:
VIR_FREE(buf);
VIR_FORCE_CLOSE(fd);
VIR_FORCE_CLOSE(passfd);
if (spawnDaemon)
unlink(path);
return -1;